Improvements for testing utilities (part 2) #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
============================================
- Coverage 91.09% 91.01% -0.09%
+ Complexity 4665 4659 -6
============================================
Files 596 596
Lines 14703 14710 +7
Branches 831 831
============================================
- Hits 13394 13388 -6
- Misses 1049 1060 +11
- Partials 260 262 +2 |
8 tasks
armiol
approved these changes
Mar 18, 2020
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxBoundedContext.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues improvements started in #1249. This PR:
BlackBoxBoundedContextleaving onlyfrom(BoundedContextBuilder)as the preferred method of creatingBlackBoxBoundedContextinstances.BlackBoxBoundedContext<?>instead of specific types.Test should not really depend on whether the context is single- or multi-tenant.
withXxx()methods that added repositories or message handling objects to existing context were also deprecated. A context for being tested must come pre-configured in the builder passed tofrom(BoundedContextBuilder)method.BlackBoxBoundedContextno longer extendsAbstractEventSubscriber. This eliminates confusion with the methods ofAbstractEventSubscriberavailable in the code of tests.