Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate checking Repository context #1299

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Sep 3, 2020

This PR:

  • Encapsulates checking if a Repository has a context.
  • Fixes the Javadoc of Repository.isRegistered() to reflect what the method does.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1299 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1299      +/-   ##
============================================
- Coverage     91.07%   91.04%   -0.03%     
+ Complexity     4748     4745       -3     
============================================
  Files           608      608              
  Lines         15088    15088              
  Branches        854      854              
============================================
- Hits          13741    13737       -4     
- Misses         1080     1083       +3     
- Partials        267      268       +1     

@alexander-yevsyukov alexander-yevsyukov marked this pull request as draft September 3, 2020 10:24
@alexander-yevsyukov alexander-yevsyukov changed the title Trigger build Encapsulate checking Repository context Sep 3, 2020
@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review September 3, 2020 10:35
@alexander-yevsyukov alexander-yevsyukov merged commit eac102c into master Sep 3, 2020
@armiol armiol deleted the trigger-build branch November 26, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants