ServerEnvironment improvements
#1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yevsyukov
requested review from
armiol,
yuri-sergiichuk and
dmitrykuzmin
yuri-sergiichuk
suggested changes
Dec 1, 2020
There was a problem hiding this comment.
@alexander-yevsyukov please consider the comments below. Also, I may be totally blind, but can you please pinpoint where is the mentioned shortcut method? I see no additions to the ServerEnvironment class at all.
dmitrykuzmin
reviewed
Dec 1, 2020
dmitrykuzmin
approved these changes
Dec 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
============================================
+ Coverage 90.91% 90.99% +0.07%
Complexity 4771 4771
============================================
Files 614 614
Lines 15165 15143 -22
Branches 859 860 +1
============================================
- Hits 13788 13780 -8
+ Misses 1105 1088 -17
- Partials 272 275 +3 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes addressing #1315. Notable changes:
ServerEnvironmentwas removed.ServerEnvironmentinstance.