-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dokka documentation to artifacts #1450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
============================================
+ Coverage 91.44% 91.45% +0.01%
+ Complexity 4979 4978 -1
============================================
Files 626 626
Lines 15347 15347
Branches 894 894
============================================
+ Hits 14034 14036 +2
+ Misses 1006 1004 -2
Partials 307 307 |
armiol
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Dokka-generated documentation as a publish artifact.
It is done by using functionality introduced in this PR in config.
Also, while updating the config, the dead code from buildSrc, like the
groovy
directory, was removed.Important details
Breaking changes were introduced in the
2.11.0
version oferror_prone_core
leading to a compilation error. The2.10.0
version was forced for all other Error Prone parts to resolve the issue.Dokka has an issue when dealing with Metaspace. The problem and its workaround were mentioned in this PR in config. This repository is large enough to run into
OutOfSpaceError
, soMaxMetaspaceSize
was manually set as a parameter to the Gradle build CLI command inbuild-on-ubuntu
andbuild-on-windows
GitHub workflows to overcome the issue.