[1.x] Allow to detect Entities which no longer match subscription criteria #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…respect to the existing `Subscription`s.
…lags. Rename the test definitions to make it specific to `Client` tests. Adjust the destination packages for commands and events.
Handle lifecycle-changing commands.
Migrate to the recently updated domain language. Extract bits to the corresponding `...TestEnv`.
…/restoring and archiving/unarchiving.
dmdashenkov
approved these changes
Mar 6, 2023
| @Override | ||
| StateConsumers.Builder<S> consumers() { | ||
| return consumers; | ||
| } | ||
|
|
||
| @Override | ||
| protected Optional<StreamObserver<SubscriptionUpdate>> chain() { | ||
| if(null == nlmConsumer) { |
There was a problem hiding this comment.
Suggested change
| if(null == nlmConsumer) { | |
| if (null == nlmConsumer) { |
| /** | ||
| * Handles the {@link EntityDeleted} events in respect to the {@code Subscription}. | ||
| */ | ||
| final class EntityRemovalHandler extends NoLongerMatchingHandler { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds an ability to subscribe to changes in Entity states, which make them no longer matching the subscription criteria.
In particular, this will always be the case if Entity becomes archived or deleted.
The new endpoint is available for Spine client under
whenNoLongerMatching()DSL, and is a part ofClient's request API:These changes will also become available to other clients (such as
web-related client), once this PR is merged.The library version is now set to
1.9.0-SNAPSHOT.10.