[1.x] Improve test Sample generation
#1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In server-side test code, there is a utility called
Sample. It allows to generate sample values for any given Proto message. However, it does a lousy job with Protostrings. In particular, it just creates them as eight random bytes treated as UTF-8-encoded JavaString.Such an approach is problematic if such values are stored either as IDs, or as entity column values into some real DB. For instance, MySQL 5.7 is not able to store such strings as-is — which was discovered when running Spine tests against MySQL in scope of
spine-rdbmsdevelopment.This changeset updates this
Sampletool, so thatstring-typed fields in Proto messages get UUID-generated values instead of random bytes.The library version is set to
1.9.0-SNAPSHOT.12.