-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dokka documentation to artifacts #140
Conversation
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=========================================
Coverage 94.73% 94.73%
Complexity 342 342
=========================================
Files 52 52
Lines 892 892
Branches 18 18
=========================================
Hits 845 845
Misses 43 43
Partials 4 4 |
Vulnerabilities regarding Dokka dependencies can be fixed only by adding dependency constraints in the config repository because they originated from transitive dependencies of the precompiled script The vulnerability of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tripolkaandrey please see my comment. LGTM otherwise.
.idea/misc.xml
Outdated
<item index="1" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.Nullable" /> | ||
<item index="2" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NullableDecl" /> | ||
<item index="3" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NullableType" /> | ||
<list size="14"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this file looks more like the original one.
I don't think we really need all these @Nullable
-related annotations.
It was closed in favour of a new PR. |
This PR adds Dokka-generated documentation as a publish artifact.
It is done by using functionality introduced in this PR in config.
Also, while updating the config, the outdated
groovy
directory was removed.Important details
In the
2.11.0
version oferror_prone_core
, they broke their contract, which led to a compilation error. The2.10.0
version was forced for all other Error Prone parts to resolve the issue.