Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itemRemoved callback isn't called when entity becomes deleted. #156

Open
YegorUdovchenko opened this issue Nov 16, 2020 · 1 comment
Open

itemRemoved callback isn't called when entity becomes deleted. #156

YegorUdovchenko opened this issue Nov 16, 2020 · 1 comment
Assignees
@armiol
Labels
Client JS Issues related to the `spine-web-client` library

Comments

@YegorUdovchenko
Copy link
Collaborator

itemRemoved callback of a subscription made with Firebase client isn't called when entity becomes deleted.

How to reproduce:

  1. Subscribe to updates of a non-existing Task by TaskId.
  2. Send CreateTask command.
  3. Receive a state of the newly-created task via itemAdded callback.
  4. Send DeleteTask command.
  5. itemRemoved for the corresponding task is never called

The corresponding test can be found here.
@YegorUdovchenko YegorUdovchenko added the Client JS Issues related to the `spine-web-client` library label Nov 16, 2020
@armiol armiol added this to v1.9 Oct 26, 2022
@armiol armiol moved this to Todo in v1.9 Nov 7, 2022
@armiol armiol self-assigned this Jan 16, 2023
@armiol armiol moved this from Todo to In Progress in v1.9 Feb 7, 2023
armiol added a commit that referenced this issue Feb 8, 2023
@armiol
Migrate the integration test case from #156.
d25e1de
@armiol armiol mentioned this issue Mar 6, 2023
Merged
@armiol
Copy link
Contributor

armiol commented Mar 6, 2023

Addressed in 1.x via #197.

@armiol armiol moved this from In Progress to Done in v1.9 Mar 6, 2023
@armiol armiol added this to v2.0 Mar 6, 2023
@armiol armiol moved this to 📋 Backlog in v2.0 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armiol armiol

Labels
Client JS Issues related to the `spine-web-client` library
Projects
v2.0
Status: 📋 Backlog
v1.9
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@armiol @YegorUdovchenko