Allow to create FirebaseCredentials from GoogleCredentials
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the `google-api-client` version to `1.30.9`. The `GoogleCredential` type is already deprecated in this library version, so the correponding `FirebaseCredentials` initializer is deprecated too.
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
+ Coverage 61.86% 62% +0.13%
- Complexity 172 178 +6
==========================================
Files 86 86
Lines 2103 2116 +13
Branches 37 38 +1
==========================================
+ Hits 1301 1312 +11
- Misses 792 795 +3
+ Partials 10 9 -1 |
|
@armiol PTAL. |
armiol
approved these changes
Mar 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
FirebaseCredentialsexpected aGoogleCredentialinstance to be passed when initializing in AppEngine environment.The problem is, in later versions of
google-api-client, theGoogleCredentialtype is already deprecated. Becausespine-webdepended on an oldergoogle-api-clientversion, this deprecation was not yet visible, but it caused problems in downstream projects.This PR both bumps the version of
google-api-clientused and updates theFirebaseCredentialsAPI so the type can be instantiated using the more "modern" class fromgoogle-auth-library.