[1.x] Delete Firebase nodes for stale topics #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, as it was implemented in `spine-web` versions prior to `1.9.0`.
|
@dmitrykuzmin PTAL. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #205 +/- ##
============================================
- Coverage 62.13% 61.89% -0.25%
Complexity 215 215
============================================
Files 96 96
Lines 2773 2758 -15
Branches 48 48
============================================
- Hits 1723 1707 -16
- Misses 1039 1040 +1
Partials 11 11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 1.9.0 release, all
Topics that were detected as "stale" (meaning there was no active subscription for a topic), were forcefully removed from Firebase RDB by deleting their corresponding nodes.In 1.9.0, this behaviour was changed, and such a forceful removal became no longer the case.
This PR addresses the issue, as it turns out, there are no other convenient means to clear outdated Firebase nodes.
Also, due to a critical vulnerability in
protobuf-js, its parent NPM dependencyfirebasewas updated to the latest available 9.x release. We don't use the latest 10.x branch of NPMfirebaseartifact, as it may not be fully compatible with our library code inspine-web1.9.0.The library version is set to 1.9.1.