go slaytherelics: add cache to AuthenticateRedis path #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use sync.Map in a few places, which can be convenient but has the notable downside of no type information. As a developer this is pretty hard to interact with, and it can be an easy source of bugs. Wrapping these in a typed wrapper does not really change anything about the underlying behavior, but should make it a bit easier for us humans.
This is one of the hottest paths in the service, since each request ends up running a bcrypt operation (which is intentionally very expensive). This is to compare the supplied token to the hashed version stored in redis. This token is actually an oauth token returned from when we previously authenticated with twitch (and not a user password or secret). Given this, caching these timebounded token values feels pretty okay and will reduce load on the server by maybe 90% if the profile is to be believed.
zdylag
force-pushed
the
zachdylag/CacheTokenRevalidation
branch
from
d04ce5c to
ca5574f
Compare
MaT1g3R
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the hottest paths in the service, since each request ends up running a bcrypt operation (which is intentionally very expensive).
This is to compare the supplied token to the hashed version stored in redis. This token is actually an oauth token returned from when we previously authenticated with twitch (and not a user password or secret).
Given this, caching these timebounded token values feels pretty okay and will reduce load on the server by maybe 90% if the profile is to be believed.