Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering to wordcloud #361

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

fellnerse
Copy link
Member

Here is what an user wrote us:

Hey it's actually not too late! It's in July, I just like to plan ahead ;)
Hm, from a development perspective I'm not sure on the best way to filter it. I think the text field is a good idea but it might not filter out the fact that some might be 'xxx' and others might be 'xxxxxxx'. Perhaps some kind of regex for repeating characters? I do think this will be a common issue for most analyses, especially for those between romantic partners :)

Kind Regards,

Lauren Spring

Hey Lauren,

thank you for using your website, your feedback and the trust in us!

I’m sorry for that late reply, I guess it’s a bit late now. But maybe for next year? It seems you love your partner really much, considering the amount of ‘xxxxx’ then in the graph :P But seriously, we could add a text field, in which you could add words that should not end up in the word cloud. would that work for you? Or a list of the most X items, where you could remove some of those?

Looking forward hearing from you,

Sebastian,

Hey I love the idea of this and thinking of generating some graphics when me and my partner's anniversary comes around. Little disappointed the word cloud seems to not filter out 'xxxxx' kisses type messages though. That seems to dominate the cloud unfortunately!

Copy link

github-actions bot commented Jun 15, 2024

Visit the preview URL for this PR (updated for commit 87871f3):

https://whatsanalyze-80665--pr361-add-filtering-to-wor-y2oxgbw5.web.app

(expires Tue, 21 Jan 2025 15:35:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5796a863d3a1b99df3fcb31feec7a39514d97aa4

Copy link
Member

@PKehnel PKehnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not able to test - In the PWA I got an wrong file format error (but same for main)

components/FeedbackBtn.vue Outdated Show resolved Hide resolved
components/charts/WordCloud.vue Outdated Show resolved Hide resolved
components/charts/WordCloud.vue Show resolved Hide resolved
@fellnerse
Copy link
Member Author

fellnerse commented Jun 25, 2024

Was not able to test - In the PWA I got an wrong file format error (but same for main)

lets try to fix it for dev then, I'll create a new branch for it, and try to find my old phone

Copy link

gitguardian bot commented Jan 14, 2025

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14799759 Triggered Generic Private Key 87871f3 localhost-key.pem View secret
14817188 Triggered Generic High Entropy Secret 87871f3 functions/backendClientRegistry.js View secret
14799760 Triggered Generic Private Key 87871f3 0.0.0.0.key View secret
14818802 Triggered Generic High Entropy Secret 87871f3 components/SubscribeBtn.vue View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Collaborator

@Adrian-Thiesen Adrian-Thiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants