Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the base for scene methods/events #142

Open
virn opened this issue May 23, 2017 · 2 comments
Open

Standardize the base for scene methods/events #142

virn opened this issue May 23, 2017 · 2 comments
Assignees
Milestone

Comments

@virn
Copy link
Contributor

virn commented May 23, 2017

Currently, for scene-load event scene is returned as 0-based, while scene-add, scene-delete events and setActiveScene method are at 1-base.

Let's review why we switched to 1-base on the later events and methods @SML-MeSo @Matrim-Cauthon and discuss what base we should use and update to.

@virn virn added this to the 2.4.0 milestone May 23, 2017
@mikeybanez
Copy link
Collaborator

My two cents here:

I'm in favor for 0-based. I don't remember if there was an original reason for a 1-based system for setActiveScene, but since Scene objects are returned through an array, it makes sense to just use 0-based indexes for everything. I think it's a fair assumption to say that many who use xjs already know a bit of programming and should already be used to point to "Scene 1" at index 0. This helps avoid a lot of + 1s in plugin code.

I'll also move this to a 3.0.0 milestone because of its breaking nature, even if there is no schedule for a version 3 yet.

@SML-MeSo
Copy link
Collaborator

add to this item changes for addToScene methods of the classes within the system directory

@virn virn self-assigned this Nov 17, 2017
@virn virn added the review label Nov 20, 2017
@virn virn assigned SML-MeSo and unassigned virn Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants