-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework how we handle Scenes #105
Comments
Scene add and remove events were accomplished in a different issue, while rename/move events are not currently planned for the application. Therefore it seems that the only scene-related improvement we can do at the moment will be #142. I'm removing this from 2.3.0. |
This issue involves scene rename/reorder events. With the upcoming #165 allowing for scene indexes, is it already possible for consumers to detect name/index changes on their own, @virn ? If not, then do we already have all necessary prerequisites to implement these events in (Noting also that #97 is a feature request for rename events.) |
It's still not possible to detect name/index changes, but I am watching CPPCORE-1048 for this. Which should then allow us to listen to these events. |
With the release of 2.7.0, the only remaining scene handling issue should be an index-change event (and a scene rename event: #97) |
We have a number of scene-related events in the pipeline (#98 for both add and remove), which will help a lot now that XSplit 2.8 has unlimited scenes.
However, this means we will have to revisit how we handle scenes. Currently we have two methods for fetching scenes:
Scene.getByName
: we've already handled duplicate scene names by returning an arrayScene.getByIdAsync
: this is very dependent on scene index under the hood. For a long time we haven't considered that index is fragile due to how users can simply reorder scenes. Now that adding and deleting scenes is available, index is now a larger source for bugs in scene-sensitive plugins.Since 1.5.0 is a small release, I'm putting this into 1.6.0 for now. When 1.5.0 is released, let's revisit the requirements to do this. Here are some suggestions for improvement.
Scene.getByUid
for better tracking of a scene as users move them around.The text was updated successfully, but these errors were encountered: