Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casting a very big shadow (API Mixins) (1.14) #2496

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Jan 31, 2020

prepends most of the api package mixins, where methods are shadowed with shadow$

Some shadowed fields were renamed to match their new names/alternatives.

BlockEntities and World package were intentionally excluded due to other prs in the works to avoid possible conflicts.

@ImMorpheus ImMorpheus added status: needs review a code review is needed version: 1.16 (u) API: 8 labels Jan 31, 2020
BlockEntities and World package were intentionally excluded due to other prs in the works.
@Zidane Zidane merged commit e549a35 into SpongePowered:api-8 Feb 5, 2020
@i509VCB i509VCB deleted the fixes/small1 branch January 30, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review a code review is needed version: 1.16 (u) API: 8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants