-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More core plugin updates #2514
More core plugin updates #2514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nitpicks, but looks good.
Some of these changes, are you absolutely sure they are still necessary? I'm not sure that the ClassInheritanceMultiMap
changes are still necessary, but I haven't done that investigation
src/main/java/org/spongepowered/common/event/SpongeCommonEventFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/entity/projectile/ThrowableEntityMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/spongepowered/common/mixin/core/item/EnderEyeItemMixin.java
Outdated
Show resolved
Hide resolved
I gave the class inheritance multimap another look and the condition it allows for is quite broad as one of the halves only requires just an interface: private boolean impl$isAssignableFromOrInterface(final Class<?> baseClass, final Class<?> clazz) {
return clazz.isInterface() || baseClass.isAssignableFrom(clazz);
} I threw a todo comment on it for now but I can still make changes if needed |
faedb98
to
4072dd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary todo comment on the ClassInheritanceMultiMapMixin.
src/main/java/org/spongepowered/common/mixin/core/util/ClassInheritanceMultiMapMixin.java
Outdated
Show resolved
Hide resolved
4072dd2
to
48db6ff
Compare
src/main/java/org/spongepowered/common/mixin/core/entity/LivingEntityMixin.java
Outdated
Show resolved
Hide resolved
48db6ff
to
fae0c58
Compare
fae0c58
to
d54e74d
Compare
No description provided.