Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More core plugin updates #2514

Merged
merged 1 commit into from
Mar 14, 2020

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Feb 24, 2020

No description provided.

Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpicks, but looks good.

Some of these changes, are you absolutely sure they are still necessary? I'm not sure that the ClassInheritanceMultiMap changes are still necessary, but I haven't done that investigation

@i509VCB
Copy link
Contributor Author

i509VCB commented Feb 27, 2020

I gave the class inheritance multimap another look and the condition it allows for is quite broad as one of the halves only requires just an interface:

private boolean impl$isAssignableFromOrInterface(final Class<?> baseClass, final Class<?> clazz) {
    return clazz.isInterface() || baseClass.isAssignableFrom(clazz);
}

I threw a todo comment on it for now but I can still make changes if needed

@i509VCB i509VCB force-pushed the api/core/fixupentities2 branch 2 times, most recently from faedb98 to 4072dd2 Compare February 27, 2020 02:59
Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary todo comment on the ClassInheritanceMultiMapMixin.

@i509VCB i509VCB force-pushed the api/core/fixupentities2 branch from 4072dd2 to 48db6ff Compare February 27, 2020 05:31
@i509VCB i509VCB force-pushed the api/core/fixupentities2 branch from 48db6ff to fae0c58 Compare March 11, 2020 15:48
@i509VCB i509VCB force-pushed the api/core/fixupentities2 branch from fae0c58 to d54e74d Compare March 11, 2020 15:52
@gabizou gabizou merged commit cdc42e4 into SpongePowered:api-8 Mar 14, 2020
@i509VCB i509VCB deleted the api/core/fixupentities2 branch January 30, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants