Add support for anchored flags. #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
force-pushed
the
api8/flags
branch
2 times, most recently
from
439a5dd to
db12db3
Compare
dualspiral
force-pushed
the
api8/flags
branch
5 times, most recently
from
2d7f3e4 to
993d913
Compare
They work similarly to before, but are anchored to the command, so come before everything else. Other updates: * Tweaked execute method as a redirect would sometimes mean a command would not fail even if there was no execution path. I need to test this with other commands first. * Create the skeleton of the /sponge chunks command - for this, I've opted not to use flags because they were incorrectly being used as mandatory arguments - might use them for config, depending on how that goes * Make ResourceKey a first class parsable citizen * Catalog types properly use the ResourceKey parser now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
They work similarly to before, but are anchored to the command, so come before everything else.
Also, redone some of the parameter translator, because flags necessesitated it.
Also tweaked execute method as a redirect would sometimes mean a command would not fail even if there was no execution path.
I need to test this with other commands first - so this isn't ready to merge just yet.looks fine, tested with a few redirected commands.