Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update keyring crate #1174

Merged
merged 3 commits into from
Mar 10, 2023
Merged

update keyring crate #1174

merged 3 commits into from
Mar 10, 2023

Conversation

eladyn
Copy link
Member

@eladyn eladyn commented Mar 2, 2023

This updates to the newest release of the keyring crate and updates the messages of the keyring query. From my testing, this is backwards compatible with the previous version – at least the parts that we were using.

Fixes #1086. (at least the last update there was, that changes in keyring, which have landed, might resolve the issue)

@eladyn eladyn requested a review from a team March 2, 2023 20:51
@eladyn
Copy link
Member Author

eladyn commented Mar 2, 2023

CI failure will be fixed by #1145.

Copy link
Member

@slondr slondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@slondr slondr requested a review from a team March 3, 2023 00:17
@eladyn eladyn merged commit ac76c82 into Spotifyd:master Mar 10, 2023
@eladyn eladyn deleted the keyring_update branch March 10, 2023 23:01
@eladyn eladyn modified the milestone: v0.3.5 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get password from KeePassXC via secret-tool
2 participants