Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shuffle setter. #1188

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Shuffle setter. #1188

merged 1 commit into from
Mar 22, 2023

Conversation

dzubybb
Copy link
Contributor

@dzubybb dzubybb commented Mar 11, 2023

New method to allow to set shuffle value, copy of #1173

@dzubybb dzubybb mentioned this pull request Mar 11, 2023
Closed
eladyn
eladyn previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works when merged with #1145. Thank you!

@eladyn eladyn added this to the v0.3.5 milestone Mar 19, 2023
slondr
slondr approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@slondr slondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eladyn eladyn merged commit a512c1b into Spotifyd:master Mar 22, 2023
@eladyn
Copy link
Member

eladyn commented Mar 22, 2023 •
edited
Loading

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slondr slondr slondr approved these changes

@eladyn eladyn eladyn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.5
Development

Successfully merging this pull request may close these issues.
4 participants
@dzubybb @eladyn @slondr @juszczukd