Add volume property #697
Merged
Add volume property #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! looks like the lint is failing though, but i do find this one to be a bit pedantic |
robinvd
previously approved these changes
Oct 29, 2020
|
I would fix it, but it's not part of the modified files |
|
Oh thats weird, maybe the lint is new. When its fixed we can restart ci
… On 29 Oct 2020, at 14:35, Hugues Morisset ***@***.***> wrote:
I would fix it, but it's not part of the modified files
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
The lint errors seem to be fixed in #695. So after that we should be able to merge this. |
|
Nice!, I'll rebase once it's merged :) |
JojiiOfficial
previously approved these changes
Nov 12, 2020
izissise
force-pushed
the
add-volume-property
branch
from
ec19072
to
03c6c45
Compare
slondr
approved these changes
Dec 29, 2020
robinvd
approved these changes
Jan 12, 2021
This was referenced Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#397
Simple PR that expose the Volume through dbus
Tested the volume is zero when nothing is playing and initial_volume when playing
It's basically zack6849 patch