Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also pin rust version on CI #769

Merged
merged 1 commit into from
Jan 14, 2021
Merged

also pin rust version on CI #769

merged 1 commit into from
Jan 14, 2021

Conversation

robinvd
Copy link
Contributor

@robinvd robinvd commented Jan 14, 2021

in reply to this comment #719 (comment)

tested on my fork and says it now uses the correct version, just like the last one this PR should also be reverted when it is fixed.

After this we can make a PR to push a new version/tag with 0.3 (#765 (comment))

@robinvd robinvd requested review from mainrs, slondr, JojiiOfficial and a team January 14, 2021 12:06
@mainrs
Copy link
Member

mainrs commented Jan 14, 2021

I actually thought about this and was sure that it would pick up the toolchain file but it seems it doesn't.

@robinvd
Copy link
Contributor Author

robinvd commented Jan 14, 2021

I thought that as well, but after looking at the cd file it makes sense, as the toolchain is installed before the repo is downloaded

@mainrs
Copy link
Member

mainrs commented Jan 14, 2021

Make sure to also yank 0.2.25 and update the changelog with notable changes for 0.3 (config for example)! :)

@robinvd robinvd merged commit 498f0d3 into Spotifyd:master Jan 14, 2021
@robinvd
Copy link
Contributor Author

robinvd commented Jan 14, 2021

i have yanked the crates.io release and make a new PR for 0.3.0

@patricksamson
Copy link

None of the MacOS builds for v0.3.0 seem to be working for me. This is the error I'm getting :

zsh: exec format error: ./spotifyd

It's as if the build wasn't executable. I also tested with 0.23.0 and 0.24.0 but those work fine so I don't think it's my machine.

@mainrs
Copy link
Member

mainrs commented Jan 15, 2021

It's the first time I've seen this kind of errors in general. Tried it on my laptop as well:

Failed to execute process './spotifyd'. Reason:
exec: Exec format error
The file './spotifyd' is marked as an executable but could not be run by the operating system.

I dunno, the workflow logs look OK to me.

@robinvd
Copy link
Contributor Author

robinvd commented Jan 15, 2021

Maybe good for a separate issue?

in any case, thats quite weird and we havent really changed ci between 0.2 and 0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants