Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump music-meta version to correct buf.readInt16BE error; allow spaces in file name; #26

Merged
merged 2 commits into from
Sep 15, 2021
Merged

fix: bump music-meta version to correct buf.readInt16BE error; allow spaces in file name; #26

merged 2 commits into from
Sep 15, 2021

Conversation

dh-sesame
Copy link
Contributor

@dh-sesame dh-sesame commented Sep 14, 2021

The scanner was failing for a game due to two issues.

  1. TypeError: buf.readInt16BE is not a function which seems to be tied to the music-metadata package ( buf.readInt16BE is not a function Borewit/music-metadata#856 ) so I set music-metadata to v7.9.1 though possibly would be better to go with latest. I was uncertain of breaking changes down the road or node requirements beyond 10.24.1.
  2. A particular game I was running the scanner on is failing due to having asset names that contain spaces. Using "shell-quote" on filePath is the proposed solution, but you all may have a preference for a different package.

I did test these changes using bash on macOS, but am submitting the above more as place markers as I know this is a critical portion of the build pipeline.

@902seanryan
Copy link
Contributor

I'm comfortable with the shell-quote solution, seems pretty simple.
As well I think leaving the version at 7.9.1 for now is ideal and we can look at updating that in the future when we have some more testing time.

Still have to test this locally myself, but otherwise it looks good to me.

@deycorinne sound reasonable?

Copy link
Contributor

@902seanryan 902seanryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works for me!

@dh-sesame
Copy link
Contributor Author

I just added package-lock.json as I noticed the build failed on Github -- had forgotten to add that in when I switched directories locally to create the PR. Just wanted to mention. Hopefully that doesn't bork things. Thanks!

@902seanryan 902seanryan merged commit 9c4d85a into SpringRoll:develop Sep 15, 2021
@dh-sesame dh-sesame deleted the bug/allow-spaces_bufReadInt16BE branch September 15, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants