feat: toggleable CC metrics #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we no longer depend on CC:T being present, we need to include() it.
|
Thank you for working on this! I wonder if we should detect CC:T's presence instead (either via doing a |
SquidDev
reviewed
Nov 21, 2022
Co-authored-by: Jonathan Coates <git@squiddev.cc>
On the off-chance we'll ever support other mods I guess??
|
<3 Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a config option,
computercraft, to enable/disable the CC metrics. This makes cc-prometheus usable as a standalone vanilla/JVM metrics exporter without requiring CC in the environment. Totally understand if this is out of scope for the mod so feel free to reject, I just thought it might make more sense than me pulling out half the exporter code.I left the startup phase as-is since the config can't be read during mod initialization. It works fine in testing for Fabric so hopefully there are no problems with that. I have not tested Forge. For both loaders, the CC mod is no longer marked as mandatory.
I also added a missing dependency,
simpleclient_common, which was causing issues under Fabric.