Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev workflow: add building for ARM platforms #1096

Merged
merged 4 commits into from
May 30, 2024

Conversation

kdavis
Copy link
Contributor

@kdavis kdavis commented May 29, 2024

Related to #1093

I missed the change for the dev workflow, so hopefully builds in https://hub.docker.com/r/squidex/squidex/tags will also be arm64 too

@SebastianStehle SebastianStehle merged commit 75686ef into Squidex:master May 30, 2024
2 checks passed
@SebastianStehle
Copy link
Contributor

I think I have to revert that. The build fails all the time now.

@SebastianStehle
Copy link
Contributor

Btw: Why do you build twice?

@kdavis
Copy link
Contributor Author

kdavis commented Jun 1, 2024

@SebastianStehle If you revert, you'll also need to revert #1093 (as that will have a similar issue)

I built twice as this commit 2642d0a specifies multiple build platforms whilst also having a load: true (which conflicts when trying to build). In the second build, I run the same params again with multiple build platforms, but without the load: true

In retrospect, it'd probably be easier to just have a matrix with the build platforms... 🤔

@SebastianStehle
Copy link
Contributor

I have solved it by adding the cleanup step: https://github.com/Squidex/squidex/blob/master/.github/workflows/release.yml#L119

Matrix build would also run the tests twice I guess, so your approach is probably better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants