Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 2 beta 17 console warning #14

Closed
jonnyklemmer opened this issue May 2, 2016 · 1 comment
Closed

Angular 2 beta 17 console warning #14

jonnyklemmer opened this issue May 2, 2016 · 1 comment

Comments

@jonnyklemmer
Copy link

Hey,

Just wanted to shoot over an issue caused by a "breaking" change in beta 17

Inside of structural directives that declare local variables, such as *ngFor, usage of #... is deprecated. Use let instead.
(ref https://github.com/angular/angular/blob/master/CHANGELOG.md)

The following is the new warning caused by the Angular2-Toaster container component template.

Template parse warnings:
"#" inside of expressions is deprecated. Use "let" instead! ("="[toasterconfig.positionClass, toasterconfig.animationClass]" class="ng-animate">
<div [ERROR ->]*ngFor="#toast of toasts" class="toast" [ngClass]="toasterconfig.typeClasses[toast.type]" (click)="cl"): ToasterContainerComponent@2:17

Should be a simple fix & I'd be happy to help with a PR! Thanks!
@Stabzs
Copy link
Owner

Stabzs commented May 4, 2016 •
edited
Loading

Thanks for the head's up!

I'm currently updating the library to @angular: 2.0.0-rc.1. This and other important upgrade features/functionality will be added with the next release. I'll leave this open for tracking in the meantime.

Stabzs added a commit that referenced this issue May 8, 2016
@Stabzs
refactor(full library): update to angular2-rc
8b73d4a 
BodyOutputType.Component (the ability to render components as the body
of the toast) has been updated to remove the soon to be deprecated
DynamicComponentLoader in favor of the ComponentResolver.

Toast rendering has been moved to its own component.

ToasterContainerComponent.Template The template has been updated to the
new *ngFor syntax.

Closes [#14](#14).
@Stabzs Stabzs mentioned this issue May 8, 2016
Merged
@Stabzs Stabzs closed this as completed in #15 May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnyklemmer @Stabzs