-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeout of 0 does not work #23
Comments
Apparently using -1 for timeout works, so maybe the documentation just needs to be updated? |
A toastconfig.timeout property of 0 should be perfectly fine. However, in this case you are assigning the toasterconfig directly to the toast instance, which is incorrect behavior. It should be bound to your toaster-container. Not doing so (and passing it to the toast directly) would cause issues and would probably explain the behavior in the first example. That said, it looks like there also may be a bug in the check for the presence of the timeout property on the toast which is incorrectly causing it to fallback to looking at the timeout defined on the toasterconfig (which if not overridden, would be the default of 5000ms). This would cause an issue in your second example. This explains why -1 is working whereas 0 is not. |
Fixed in 0.3.2-rc.1. |
Hello, i have tried to override the timeout for errors to make them sticky and it does not work.
I have tried the below and no matter what, it goes away after 5 seconds.
The text was updated successfully, but these errors were encountered: