Reduce allocation on TimerMessage by reusing Message.CreatedTimestamp

StackExchange · May 23, 2021 · 1eeaf4c · 1eeaf4c
1 parent f2a7671
commit 1eeaf4c
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/StackExchange.Redis/ResultProcessor.cs b/src/StackExchange.Redis/ResultProcessor.cs
@@ -329,6 +329,8 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
 
         public sealed class TimingProcessor : ResultProcessor<TimeSpan>
         {
+            private static readonly double TimestampToTicks = TimeSpan.TicksPerSecond / (double)Stopwatch.Frequency;
+
             public static TimerMessage CreateMessage(int db, CommandFlags flags, RedisCommand command, RedisValue value = default(RedisValue))
             {
                 return new TimerMessage(db, flags, command, value);
@@ -346,9 +348,9 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
                     TimeSpan duration;
                     if (message is TimerMessage timingMessage)
                     {
-                        var watch = timingMessage.Watch;
-                        watch.Stop();
-                        duration = watch.Elapsed;
+                        var timestampDelta = Stopwatch.GetTimestamp() - timingMessage.CreatedTimestamp;
+                        var ticks = (long)(TimestampToTicks * timestampDelta);
+                        duration = new TimeSpan(ticks);
                     }
                     else
                     {
@@ -361,12 +363,10 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
 
             internal sealed class TimerMessage : Message
             {
-                public readonly Stopwatch Watch;
                 private readonly RedisValue value;
                 public TimerMessage(int db, CommandFlags flags, RedisCommand command, RedisValue value)
                     : base(db, flags, command)
                 {
-                    Watch = Stopwatch.StartNew();
                     this.value = value;
                 }