Seems like FailureType is not correctly indicating authentication error

[tavisca-manpreet]

No description provided.

[tavisca-manpreet]

In case of incorrect credentials, I am getting StackExchange.Redis.RedisConnectionException exception. To differentiate Authentication errors, the code seems to have an enum of failure type. But in case of authentication error also, I am getting FailureType as "UnableToConnect".

[NickCraver]

Which version of the library are you using?

For info: this was improved in 2.6.66+, release notes and links here: https://stackexchange.github.io/StackExchange.Redis/ReleaseNotes#2666

[tavisca-manpreet]

I am using 2.6.90 version and the the screenshot is of the same code. ExceptionFactory seems to be setting same failure type in case of all UnableToConnect errors.

[NickCraver]

Can you post the actual error message and type you're seeing? Look at this from my view: all I have is a screenshot of code, I'm not sure what error you're seeing and what you're expecting to see. e.g. "is it including the test about it being an authentication failure?" - give us something to go on here...

[tavisca-manpreet]

Exception message: It was not possible to connect to the redis server(s). There was an authentication failure; check that passwords (or client certificates) are configured correctly: (RedisServerException) Error: WRONGPASS invalid username-password pair or user is disabled.
Type: StackExchange.Redis.RedisConnectionException

[tavisca-manpreet]

I am trying to handle authentication failures in my code. To test this scenario, when I pass incorrect credentials , I am getting exception with the correct message but the "FailureType" in the exception seems to be not correct . I need a differentiator in case of authentication errors apart from the exception message. FailureType seems to be the correct field for it. But the value getting returned in this case in FailureType is "UnableToConnect" which I felt was incorrect as the enum has a better alternative to represent authentication failure.

[tavisca-vshah]

I agree with the @tavisca-manpreet point, enum StackExchange.Redis.ConnectionFailureType already have AuthenticationFailure Field. Expected behaviour should be to set FailureType to ConnectionFailureType.AuthenticationFailure when there is authetication failure.

[NickCraver]

Hey y'all - I'm just slammed with actual work stuff this week (this isn't the thing we're paid for :)) but wanted to say yes: completely agree. I haven't gotten a chance to look at this (hopefully later this week but we'll see how it goes), but I appreciate the clarification and additional detail. The request absolutely seems reasonable. Adding to the message it was because of auth and not a generic connection failure was something I only recently did a few months ago, and likely missed this aspect - will take a peek and report back.

[NickCraver]

Had to wait on some builds this morning so poked at how big this is - super minor to adjust/test, fix is up here: #2367

[tavisca-manpreet]

Thanks @NickCraver for the quick fix.

[NickCraver]

@tavisca-manpreet one note here: you could check the type on InnerException if you wanted until this is available on NuGet, in case that unblocks :)

[deychandan]

Hi @NickCraver,
I'm getting following error while try to run my .Net Core WebAPI. But with the same configuration it's working in another project.

Redis version: StackExchange.Redis v2.0.601(tried with latest version but no luck)
Redis Config:
"RedisSettings": {
"Endpoint": "xxxxxxxxx:6379",
"Password": "xxxxxxxxxx",
"Ssl": false,
"AbortOnConnectFail": true,
"KeepAlive": 30,
"SyncTimeout": 3000,
"ConnectTimeout": 4000,
"ConnectRetry": 3,
"sslprotocols": "tls12"
}

Thanks
Chandan

[NickCraver]

I'm not sure how your connection is being created, but sslprotocols being specified while also turning SSL off is curious - any idea what's going on there?

[deychandan]

Hi @NickCraver
Sorry my bad wrongly added "sslprotocols". Following the config which is working in one project but not working in other project
"RedisSettings": {
"Endpoint": "sis-redis.development.us.markerspro.net:6379",
"Password": "bHoK4c2kHUuNj0WfnxmkWeVVo3DMVbnJ",
"Ssl": false,
"AbortOnConnectFail": true,
"KeepAlive": 30,
"SyncTimeout": 3000,
"ConnectTimeout": 4000,
"ConnectRetry": 3
}