Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply default database rules on IServer #1468

Merged
merged 2 commits into from
May 29, 2020
Merged

Apply default database rules on IServer #1468

merged 2 commits into from
May 29, 2020

Conversation

mgravell
Copy link
Collaborator

  • impacts DBSIZE, FLUSHDB, KEYS, SCAN
  • changes default parameter value from 0 to -1 (needs rebuild of caller to recognize, this is fine)
  • adds a helper method to standardize the behavior between call-sites

@mgravell
apply default database rules(-1=>config) on IServer - DBSIZE, FLUSHDB…
a7a831c 
…, KEYS, SCAN; this normalizes it with IDatabase[Async]
@mgravell mgravell mentioned this pull request May 21, 2020
Closed
NickCraver
NickCraver approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I’d suggest adding what the negative passed value was (for easier debugging - since it’s almost always logs) in the argument exception is all :)

@mgravell mgravell merged commit 572b918 into master May 29, 2020
@NickCraver NickCraver deleted the server-default-db branch July 31, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgravell @NickCraver