Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set a default serverselection stratergy in case there was a fault getting the servertype #1532

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Don't set a default serverselection stratergy in case there was a fault getting the servertype #1532

merged 1 commit into from
Aug 25, 2020

Conversation

deepakverma
Copy link
Collaborator

@deepakverma deepakverma mentioned this pull request Jul 15, 2020
Closed
@deepakverma deepakverma marked this pull request as ready for review July 15, 2020 23:42
NickCraver
NickCraver approved these changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me - having trouble getting CI to kick here (GitHub bug).

The default is single-server already, so not setting in the initial case is not a problem (same result) and this would only apply to reconnects.

@NickCraver NickCraver linked an issue Aug 25, 2020 that may be closed by this pull request
ServerSelectionStrategy set to standalone for a clustered cache #1501
Closed
@NickCraver NickCraver merged commit 026ce92 into StackExchange:main Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServerSelectionStrategy set to standalone for a clustered cache
2 participants
@deepakverma @NickCraver