Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow XTRIM maxLength equal 0 #2030

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Allow XTRIM maxLength equal 0 #2030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
319596e
Allow XTRIM maxLength equal 0
NicoAvanzDev Mar 9, 2022
7d69795
Update src/StackExchange.Redis/RedisDatabase.cs
NickCraver Mar 10, 2022
aa61921
Merge branch 'main' into pr/2030
NickCraver Mar 10, 2022
c05d417
Add release notes
NickCraver Mar 10, 2022
bd37f5b
ehhhhhh, ordering
NickCraver Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- Fix [#1988](https://github.com/StackExchange/StackExchange.Redis/issues/1988): Don't issue `SELECT` commands if explicitly disabled ([#2023 by NickCraver](https://github.com/StackExchange/StackExchange.Redis/pull/2023))
- Fix: Allow `XTRIM` `MAXLEN` argument to be `0` ([#2030 by NicoAvanzDev](https://github.com/StackExchange/StackExchange.Redis/pull/2030))
- Adds: `ConfigurationOptions.BeforeSocketConnect` for configuring sockets between creation and connection ([#2031 by NickCraver](https://github.com/StackExchange/StackExchange.Redis/pull/2031))

## 2.5.43
Expand Down
4 changes: 2 additions & 2 deletions src/StackExchange.Redis/RedisDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3402,9 +3402,9 @@ private Message GetSingleStreamReadMessage(RedisKey key, RedisValue afterId, int

private Message GetStreamTrimMessage(RedisKey key, int maxLength, bool useApproximateMaxLength, CommandFlags flags)
{
if (maxLength <= 0)
if (maxLength < 0)
{
throw new ArgumentOutOfRangeException(nameof(maxLength), "maxLength must be greater than 0.");
throw new ArgumentOutOfRangeException(nameof(maxLength), "maxLength must be equal to or greater than 0.");
}

var values = new RedisValue[2 + (useApproximateMaxLength ? 1 : 0)];
Expand Down