-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OBJECT REFCOUNT #2087
Support OBJECT REFCOUNT #2087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - a few doc tweaks and good to go 👍 - since it's just docs I'll merge in and watch builds. Need to add release notes for this one yet!
I'll try and tweak this a bit - added a not-exist case locally and that'll throw because it's nil coming back from Redis. We can either make that 0, or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - thanks again! 👍
@Avital-Fine I changed the return here given what redis returns and consistency with a few other APIs for that case (null does clearly indicate missing) - can you confirm this makes sense to you? If not we can tweak further. |
@NickCraver Makes sense, but need to update the doc ;) |
return null if the key does not exist
return null if the the key does not exist
revert mistake
@NickCraver Sorry! Always forget the release notes 😅 |
Good call - thanks! |
https://redis.io/commands/object-refcount/
#2055