Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve sync-context issues (missing configureawait) in the multiplexer #2229

Merged
merged 8 commits into from
Aug 24, 2022
Merged

Resolve sync-context issues (missing configureawait) in the multiplexer #2229

merged 8 commits into from
Aug 24, 2022

Conversation

mgravell
Copy link
Collaborator

ref #2223 for context

@mgravell mgravell requested a review from NickCraver August 24, 2022 12:25
@mgravell mgravell marked this pull request as ready for review August 24, 2022 12:25
NickCraver
NickCraver approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Just needs some release note lovin :)

@NickCraver NickCraver linked an issue Aug 24, 2022 that may be closed by this pull request
sync-over-async in ConnectionMultiplexer #2223
Closed
@mgravell mgravell merged commit 2a0468e into main Aug 24, 2022
@mgravell mgravell deleted the issue2223 branch August 24, 2022 13:16
@NickCraver NickCraver mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sync-over-async in ConnectionMultiplexer
2 participants
@mgravell @NickCraver