Pants: add some missing external dependencies #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
winem,
arm4b,
nzlosh,
rush-skills,
amanda11 and
a team
pull-request-size
bot
added
the
size/L
nzlosh
approved these changes
Mar 10, 2023
This reverts the tools/ portion commit c805e33. The updates for the networkx library inadvertently touched graphviz usage. Pylint is now complaining that `add_node` does not exist on Digraph, so we revert this change.
cognifloyd
force-pushed
the
pants-external-reqs
branch
from
af58fe9
to
780ad4c
Compare
rush-skills
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
I noticed a few deps that were not accounted for, so I added them to the BUILD metadata and regenerated the lockfile.
This re-introduces the
pysocksdep to st2client so that the pants BUILD metadata also has the change introduced in:These deps are for tools that will never end up in a wheel, so pants will only ever use these if it has to run these tools for some reason:
pikais used bytools/direct_queue_publisher.pygraphvizis used bytools/st2-analyze-links.pyandtools/visualize_action_chain.pyAdding the
graphvizdep revealed a bug added in c805e33 where an update meant to fix usage of the networkx library inadvertently also changed usage of the graphviz library. This reverts the graphviz portion of that commit.I also noted that
st2actions/conf/logging.confneeds thepython-json-loggerdep (which is already in the lockfile).Finally, I noticed some code that imports
geventin atry/except ImportErrorblock. Apparently there was some WIP work to allow usinggeventinstead ofeventlet. I added a commented-outpython_requirementfor this and a TODO to explain where I think support is still lacking. I left it commented out, because pants does not have a good way to support optional dependencies yet. At some point maybe we can revisit switching (or allow switching) fromeventlettogevent.Pants documentation
python_requirementtargetdependenciesfield