Pants: add dependencies to the st2* python_distributions (except st2common/st2tests)
#5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
winem,
arm4b,
nzlosh,
rush-skills,
amanda11 and
a team
pull-request-size
bot
added
the
size/M
cognifloyd
changed the title
cognifloyd
changed the title
python_distributions (except st2common/st2tests)
cognifloyd
force-pushed
the
pants-python_distributions-deps-2
branch
from
63378c9
to
1b90c02
Compare
cognifloyd
commented
Mar 10, 2023
| # controller routes are wired up via st2common/st2common/openapi.yaml | ||
| "./controllers", | ||
| "./controllers/v1", | ||
| # "./controllers/exp", |
There was a problem hiding this comment.
No APIs are in the experimental folder right now. So, I left this commented out.
This was referenced Mar 10, 2023
nzlosh
approved these changes
Mar 10, 2023
rush-skills
approved these changes
Mar 10, 2023
cognifloyd
force-pushed
the
pants-python_distributions-deps-2
branch
from
1b90c02
to
43ca9ad
Compare
cognifloyd
force-pushed
the
pants-python_distributions-deps-2
branch
from
43ca9ad
to
2678cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
Like #5925, which adds dependencies for the
python_distributionforst2common, this PR adds the remaining dependencies for the otherst2*componentpython_distributiontargets. It also skipsst2testswhich requires quite a few more changes in #5929.It also adds a note to
pants.tomlto make it clear that pants will generate asetup.pyfile for us.Pants documentation
python_distributiontarget