Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bionic/el7 and add el9 #187

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove bionic/el7 and add el9 #187

wants to merge 5 commits into from

Conversation

amanda11
Copy link
Contributor

No description provided.

Copy link

@mamercad mamercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update CHANGELOG.rst.

@@ -38,7 +38,6 @@ jobs:
docker-compose version
nodejs -v
jq --version
package_cloud version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of package_cloud version intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting an error with not found - so just trying to debug it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving PR into draft whilst I get the circleCI to pass...
This is the only repo that uses the package_cloud.sh that had that package_cloud version call - so just seeing what's going on...

@amanda11 amanda11 marked this pull request as draft February 26, 2024 13:31
@amanda11 amanda11 mentioned this pull request Feb 26, 2024
@amanda11
Copy link
Contributor Author

Putting on hold, I think we need to get NodeJS up to Node 18 at least before we can do EL9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants