Revert change to segment reader path #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenYCChou
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Thanks for contribution to fix this! Yes, LastCheckpoint() API was changed in TSDB 3.0.
The same approach was applied in caller in series_cache, and @jkohen and I had a thread talking about it. Unfortunately we didn't catch the caller in Tail().
I will create an issue to track how we can improve the test here.
Thanks again, @mans0954!
|
Created an issue #179 for the test coverage. Will merge this PR now. |
|
My bad - won't merge because we still want Travis to be happy! |
|
My understanding is all the tests pass (see the raw log from travis) but our script complains that COVERALLS_TOKEN is undefined, which is unrelated to the code here. Will still squash and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #160