Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip samples that have a NaN value. #186

Merged
merged 4 commits into from
Oct 10, 2019
Merged

Skip samples that have a NaN value. #186

merged 4 commits into from
Oct 10, 2019

Conversation

jkschulz
Copy link
Contributor

@jkschulz jkschulz commented Oct 9, 2019

Fixes #152
Tested by running the script provided in issue #152 with image built with the fix.

Screen Shot 2019-10-08 at 9 26 35 PM

@jkschulz jkschulz requested a review from StevenYCChou October 9, 2019 20:59
@StevenYCChou StevenYCChou mentioned this pull request Oct 10, 2019
Closed
StevenYCChou
StevenYCChou approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@StevenYCChou StevenYCChou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and tests look good to me, but please consider the minor readability comments I gave before merging this PR back to master.

retrieval/transform_test.go Show resolved Hide resolved
retrieval/transform_test.go Outdated Show resolved Hide resolved
retrieval/transform_test.go Show resolved Hide resolved
StevenYCChou
StevenYCChou approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@StevenYCChou StevenYCChou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkschulz jkschulz merged commit 596df4c into master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenYCChou StevenYCChou StevenYCChou approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Count values shoot off to infinity
3 participants
@jkschulz @StevenYCChou @googlebot