Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add stale #8

Merged
merged 4 commits into from
Mar 14, 2022
Merged

✨ Add stale #8

merged 4 commits into from
Mar 14, 2022

Conversation

flaxel
Copy link
Contributor

@flaxel flaxel commented Mar 7, 2022

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

add stale

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@flaxel flaxel added enhancement New feature or request major Pull requests with breakable changes labels Mar 7, 2022
@flaxel flaxel requested a review from a team March 7, 2022 15:56
@flaxel flaxel marked this pull request as ready for review March 7, 2022 16:10
@flaxel flaxel requested a review from a team March 9, 2022 12:45
Stummi
Stummi approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@Stummi Stummi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this is just a "wrapper" around the official stale workflow only with a few defaults set? LGTM

@flaxel
Copy link
Contributor Author

flaxel commented Mar 10, 2022

If I understand correctly, this is just a "wrapper" around the official stale workflow only with a few defaults set? LGTM

Correct, so that you don't have to write the same lines again and the bumping for the action is only necessary in one repository.

@flaxel flaxel force-pushed the add-yamllint branch 2 times, most recently from 1404680 to 71222f5 Compare March 14, 2022 09:50
Base automatically changed from add-yamllint to main March 14, 2022 09:52
@flaxel flaxel merged commit 9ea34e6 into main Mar 14, 2022
@flaxel flaxel deleted the add-stale branch March 14, 2022 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stummi Stummi Stummi approved these changes

@linda-knechtel linda-knechtel linda-knechtel approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request major Pull requests with breakable changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaxel @Stummi @linda-knechtel