Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump libs #46

Merged
merged 3 commits into from
Aug 4, 2022
Merged

bump libs #46

merged 3 commits into from
Aug 4, 2022

Conversation

soemo
Copy link
Contributor

@soemo soemo commented Aug 4, 2022 •
edited
Loading

bump libs to reduce the vulnerabilities https://github.com/Staffbase/security-dump/blob/main/metrics/reports/soemo.md

  • remove unused package-lock.json

The bump of node-fetch needs extra effort. Will be done later

@soemo soemo requested review from flaxel and martinbrylski August 4, 2022 10:18
flaxel
flaxel approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@flaxel flaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to bump the node version too? 🤔

@soemo
Copy link
Contributor Author

soemo commented Aug 4, 2022

Do you want to bump the node version too? thinking

where is the node version set?

@flaxel
Copy link
Contributor

flaxel commented Aug 4, 2022

where is the node version set?

I can only find it in the action.yml file. 😆
https://github.com/Staffbase/github-action-jira-release-tagging/blob/master/action.yml

@soemo soemo requested a review from flaxel August 4, 2022 11:25
@soemo soemo merged commit 2d53bf2 into master Aug 4, 2022
@soemo soemo deleted the SP-000-bump-libs branch August 4, 2022 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flaxel flaxel flaxel approved these changes

@martinbrylski martinbrylski Awaiting requested review from martinbrylski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soemo @flaxel