⬆️ Bump yq version #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaxel
force-pushed
the
bump-yq
branch
4 times, most recently
from
bcb5002 to
03e65f5
Compare
flaxel
requested review from
0x46616c6b,
axdotl,
ricoberger and
a team
and removed request for
a team
flaxel
commented
Jul 1, 2022
| @@ -163,40 +163,44 @@ runs: | |||
| if [[ ( $GITHUB_REF == refs/heads/master || $GITHUB_REF == refs/heads/main ) && -n "${{ inputs.gitopsstage }}" ]]; then | |||
| echo "Run update for STAGE" | |||
| while IFS= read -r line; do | |||
| array=($line) | |||
action.yml
Outdated
Comment on lines
167
to
174
| echo "Check if path $line exists and get old current version" | ||
| yq r -e $line | ||
| yq -e .${array[1]} ${array[0]} | ||
| echo "Run update $line ${{ inputs.dockerregistry }}/${{ inputs.dockerimage }}:${{ steps.preparation.outputs.tag }}" | ||
| yq w -i $line ${{ inputs.dockerregistry }}/${{ inputs.dockerimage }}:${{ steps.preparation.outputs.tag }} | ||
| yq -i .${array[1]}=\"${{ inputs.dockerregistry }}/${{ inputs.dockerimage }}:${{ steps.preparation.outputs.tag }}\" ${array[0]} |
There was a problem hiding this comment.
migrated the calls from version 3 to 4
flaxel
commented
Jul 2, 2022
Comment on lines
-153
to
-157
| # download and install yq | ||
| sudo wget -O /usr/local/bin/yq https://github.com/mikefarah/yq/releases/download/3.4.1/yq_linux_amd64 | ||
| sudo chmod +x /usr/local/bin/yq |
There was a problem hiding this comment.
yq is already part of the github action with ubuntu 20: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md#tools
Comment on lines
-159
to
-163
| git clone https://${{ inputs.gitopsuser }}:${{ inputs.gitopstoken }}@github.com/${{ inputs.gitopsorganization }}/${{ inputs.gitopsrepository }}.git .github/${{ inputs.gitopsrepository }} | ||
| cd .github/${{ inputs.gitopsrepository }} | ||
| echo "Repository ${{ inputs.gitopsorganization }}/${{ inputs.gitopsrepository }} was cloned successfully " |
There was a problem hiding this comment.
use explicit checkout action
0x46616c6b
approved these changes
Jul 12, 2022
* 🎨 reformat table * 🔥 remove gitopsenabled * 🔥 remove dockerenabled * 📝 improve usage documentation * 🎨 add missing docker image * 🚚 rename parameters (#45)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Checklist