Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw proper errors when converting device object #53

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: throw proper errors when converting device object #53

merged 1 commit into from
Oct 10, 2023

Conversation

jreimone
Copy link
Contributor

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

The user needs a proper error message when invalid information for the devices are provided in the prepare comment.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@jreimone jreimone marked this pull request as ready for review October 10, 2023 08:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

@jreimone jreimone added the minor label Oct 10, 2023
@jreimone jreimone merged commit 4458208 into main Oct 10, 2023
@jreimone jreimone deleted the fix-v1.0.4-bugs branch October 10, 2023 08:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jreimone