Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evebox - pre and post upgrade scripts #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

evebox - pre and post upgrade scripts #1

wants to merge 1 commit into from

Conversation

jasonish
Copy link

The idea here is to do the best thing for the user. With EveBox,
if the user choosed to install the maintainers configuration files,
it will be wide open on port 5636. This is not what we want with
SELKS, instead we want to lock it down to localhost so we get
the authentication provided by SELKS/Scirius.

So instead, include a copy of the desired /etc/default/evebox
file in this package and make sure it gets installed after
EveBox is upgraded. EveBox is also upgraded in its own step
with options to prevent any prompting about configuration files.

Additonally, use this as an opportunity to replace the EveBox
repo with that of the stable version, which I believe has hit
a state where it might make more sense to use, rather than the
one built directly from git master on each commit.

I'd like to think the idea here can be extended to other packages to take less decision making away from the end user.

There is however a chicken and egg problem - how do you introduce new logic into an upgrade. One solution is the double upgrade. The first upgrade might get a new version of this package. Running it again applies new logic. The second is break out the "post" logic into a second script that is run after the upgrade is complete?

The idea here is to do the best thing for the user. With EveBox,
if the user choosed to install the maintainers configuration files,
it will be wide open on port 5636. This is not what we want with
SELKS, instead we want to lock it down to localhost so we get
the authentication provided by SELKS/Scirius.

So instead, include a copy of the desired /etc/default/evebox
file in this package and make sure it gets installed after
EveBox is upgraded. EveBox is also upgraded in its own step
with options to prevent any prompting about configuration files.

Additonally, use this as an opportunity to replace the EveBox
repo with that of the stable version, which I believe has hit
a state where it might make more sense to use, rather than the
one built directly from git master on each commit.
@pevma
Copy link
Member

pevma commented Apr 23, 2017

May be this is good timing with SELKS 3 to SELKS 4 upgrade where in the later we would have less to worry about since it will come with the changed/updated evebox repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants