Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDDL fixes during object property annotation #27

Merged
merged 17 commits into from
May 31, 2023
Merged

Conversation

ChengshuLi
Copy link
Member

@ChengshuLi ChengshuLi commented May 27, 2023

No description provided.

Copy link
Member Author

@ChengshuLi ChengshuLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed myself.

@ChengshuLi
Copy link
Member Author

Verification script also passed.

@ChengshuLi ChengshuLi requested a review from wensi-ai May 30, 2023 21:33
@@ -26,7 +24,7 @@
(:goal
(and
(not
(covered ?quartz.n.02_1 ?dirt.n.02_1)
(covered ?countertop.n.01_1 ?dirt.n.02_1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be a quartz countertop?

Copy link
Member Author

@ChengshuLi ChengshuLi May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not guaranteed. But I think the original bddl definitely has some problems. quartz.n.02 refers to a piece of rock, but I think the task is about cleaning a quartz countertop (at least that's what I found when googling "clean quartz"). Maybe it's okay to approximate this task with "clean countertop".

@ChengshuLi ChengshuLi merged commit e52e41f into develop May 31, 2023
@ChengshuLi ChengshuLi deleted the eric-bddl-fix-3 branch May 31, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants