feat: added Unity build tasks to BuildTasksContainer #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stan-osipov
requested changes
Aug 4, 2021
| namespace StansAssets.Build.Pipeline | ||
| { | ||
| class DefaultBuildTasksProvider : IBuildTasksProvider | ||
| { | ||
| public IBuildTasksContainer GetBuildSteps(IUserEditorBuildSettings buildSettings) | ||
| public IBuildTasksContainerFull GetBuildSteps(IUserEditorBuildSettings buildSettings) |
There was a problem hiding this comment.
IBuildTasksProvider Should only provide steps for the current build system.
IBuildTasksContainerFull - doesn't make much scene in terms of API.
We want to only display those additional default Unity steps in the editor window. No need to change the tool API.
Comment on lines
9
to
26
| public interface IBuildTasksContainerFull : IBuildTasksContainer | ||
| { | ||
| /// <summary> | ||
| /// Pre process build steps. Order matters. | ||
| /// </summary> | ||
| IReadOnlyList<IOrderedCallback> UnityPreBuildTasks { get; } | ||
|
|
||
| /// <summary> | ||
| /// Post process build steps. Order matters. | ||
| /// </summary> | ||
| IReadOnlyList<IOrderedCallback> UnityPostBuildTasks { get; } | ||
|
|
||
| /// <summary> | ||
| /// Scene process build steps. Order matters. | ||
| /// </summary> | ||
| IReadOnlyList<IOrderedCallback> UnityProcessSceneTasks { get; } | ||
| } | ||
| } |
There was a problem hiding this comment.
Again we don't really need this to be a part of our API
vdenysiuk-sa
force-pushed
the
feat/all-build-tasks-collection
branch
2 times, most recently
from
6edec44
to
7f0f9f3
Compare
This was
linked to
issues
Jan 17, 2022
pavlo-klymentenko-legacy
requested review from
pavlo-klymentenko-legacy and
stan-osipov
|
This PR depends on the custom branch of the com.stansassets.foundation package. |
|
Extend the Unity related build steps visualization:
I have also
|
| @@ -0,0 +1,7 @@ | |||
| namespace StansAssets.Build.Pipeline | |||
| { | |||
| public interface IBuildStepsViewModelProvider | |||
…ity build tasks: IPreprocessBuildWithReport, IPostprocessBuildWithReport, IProcessSceneWithReport
- collecting of Unity built-in tasks is moved to BuildPipelineTab
…ps in-editor visualization
alexey-yaremenko
force-pushed
the
feat/all-build-tasks-collection
branch
from
9cc52a3
to
d8d3e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
BuildTaskContainer now contains user's Unity build tasks too.
If user's tasks implement interfaces IPreprocessBuildWithReport, IPostprocessBuildWithReport, IProcessSceneWithReport it will be added to the list
Testing status
Manual testing status
Tested manually in Unity Editor