Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitx 6841 fix pkg cache flag #70

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Conversation

tjknoth
Copy link
Contributor

@tjknoth tjknoth commented Feb 15, 2024

This ensures that the -pkg-cache flag takes precedence over the corresponding field in a .proj file.

To do so we extend the ProjParams struct with an additional field: the struct represents any command line info that might override .proj file behavior. The ProjManager is responsible for finding .pkg files; it combines all of the directory parameters and a possible -disable-cache flag to compute the actual value (of type String|False).

@CuppoJava CuppoJava merged commit e7c5909 into master Apr 11, 2024
3 checks passed
@CuppoJava CuppoJava deleted the JITX-6841-fix-pkg-cache-flag branch April 11, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants