Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cvars keep resetting to default after 10.2.7 patch #80

Closed
biterbol opened this issue May 13, 2024 · 1 comment · Fixed by #81
Closed

Some cvars keep resetting to default after 10.2.7 patch #80

biterbol opened this issue May 13, 2024 · 1 comment · Fixed by #81

Comments

@biterbol
Copy link

"NameplateOverlapH" and "NameplateOverlapV" cvars are resetting to default everytime i login.
I tried disabling every addon except aio but its still resetting.
Enforce Settings on Startup is enabled. I have tried backup settings and restore settings multiple times but it doesn't seem to work.
Screenshot_1
romracer added a commit to romracer/AdvancedInterfaceOptions that referenced this issue May 31, 2024
@romracer
Fix CvarUtil pattern matching
6486492 
Seems like all the different clients have slightly different SharedXML/CvarUtil now.
This should catch anything SharedXML/CvarUtil.lua or SharedXML/ClassicCvarUtil.lua (SoD)
or Blizzard_SharedXML/CvarUtil.lua  (Cata Classic) now.

Fixes Stanzilla#80
@romracer romracer mentioned this issue May 31, 2024
Merged
@romracer
Copy link
Contributor

Hi,

I was noticing CVars resetting on SoD too. The addon will remove a CVar from its list if it finds another addon modifies it, except the built-in Blizzard tool. Except the pattern matching for the built-in CvarUtil no longer matches some of the filenames in the various WoW clients.

Try the fix in the linked PR (#81) and see if it helps. It has fixed the issue on SoD for me.

Stanzilla pushed a commit that referenced this issue May 31, 2024
@romracer @Stanzilla
Fix CvarUtil pattern matching
a778f6b 
Seems like all the different clients have slightly different SharedXML/CvarUtil now.
This should catch anything SharedXML/CvarUtil.lua or SharedXML/ClassicCvarUtil.lua (SoD)
or Blizzard_SharedXML/CvarUtil.lua  (Cata Classic) now.

Fixes #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CvarUtil pattern matching romracer/AdvancedInterfaceOptions
2 participants
@romracer @biterbol