Fix bug loading on Shadowlands, also allows loading on BFA #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you! You can just check for the existence of the template and avoid the shadowlands check, might still be nice to have for other bugs but for now we don't need it here :) |
In Shadowlands one major API change was that frames no longer have a backdrop by default, so frames which are setting a backdrop need to inherit from 'BackdropTemplate'.
jayotterbein
force-pushed
the
shadowlands
branch
from
d4fd71a to
f1c56da
Compare
|
Is something like this what you're looking for then? |
Stanzilla
requested changes
Aug 21, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Shadowlands one major API change was that frames no longer have a backdrop by default, so frames which are setting a backdrop need to inherit from 'BackdropTemplate'.