Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring PR "Synchronize" Events Causes Check to Disappear Resolving Conflicts #81

Closed
romeara opened this issue Feb 17, 2019 · 1 comment
Closed

Ignoring PR "Synchronize" Events Causes Check to Disappear Resolving Conflicts #81

romeara opened this issue Feb 17, 2019 · 1 comment
Assignees
@romeara
Labels
bug
Milestone
0.2.1

Comments

@romeara
Copy link
Member

romeara commented Feb 17, 2019

Currently, Chronicler ignores "synchronize" webhook events. While these don't represent changes we expect to change the status of a PR< it does change the commit sha, and therefore the checks shown, resulting in Chronicler's check disappearing
@romeara romeara added the bug label Feb 17, 2019
@romeara romeara self-assigned this Feb 17, 2019
romeara added a commit that referenced this issue Feb 18, 2019
@romeara
GH-81 Add synchronize to list of actions sent for processing
9a11fb7 
Add "synchronize" to supported actions to keep chronicler status check
existing after a merge conflict is resolved by a user
@romeara romeara mentioned this issue Feb 18, 2019
Merged
romeara added a commit that referenced this issue Feb 18, 2019
@romeara
GH-81 Add synchronize PR event fix to release notes
1715db2
romeara added a commit that referenced this issue Feb 18, 2019
@romeara
GH-81 Add synchronize to list of actions sent for processing
d4fd4e3 
Add "synchronize" to supported actions to keep chronicler status check
existing after a merge conflict is resolved by a user
romeara added a commit that referenced this issue Feb 18, 2019
@romeara
GH-81 Add synchronize PR event fix to release notes
856b946
@romeara
Copy link
Member Author

romeara commented Feb 18, 2019

Merged to master

@romeara romeara closed this as completed Feb 18, 2019
@romeara romeara added this to the 0.2.1 milestone Feb 21, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romeara romeara

Labels
bug
Projects
None yet
Milestone
0.2.1
Development

No branches or pull requests
1 participant
@romeara