Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support Update Strategy for FE/BE/CN component #594

Merged

Conversation

yandongxiao
Copy link
Collaborator

Description

see #592

Checklist

For operator, please complete the following checklist:

  • run make generate to generate the code.
  • run golangci-lint run to check the code style.
  • run make test to run UT.
  • run make manifests to update the yaml files of CRD.

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

@yandongxiao yandongxiao force-pushed the enhancement/support-update-strategy branch 5 times, most recently from bd6448a to f408557 Compare November 12, 2024 08:20
@yandongxiao yandongxiao requested a review from dengliu November 12, 2024 08:23
Signed-off-by: yandongxiao <yandongxiao@starrocks.com>
@yandongxiao yandongxiao force-pushed the enhancement/support-update-strategy branch from f408557 to e297a01 Compare November 12, 2024 08:24
@yandongxiao yandongxiao merged commit 0c8aefb into StarRocks:main Nov 12, 2024
6 checks passed
@yandongxiao yandongxiao added v1.9.9 enhancement New feature or request labels Nov 22, 2024
@@ -683,6 +690,12 @@ starrocksCnSpec:
# volumeMounts:
# - mountPath: /opt/starrocks/cn/storage
# name: cn-data # append -data to the end of the name of the starrocksCnSpec.storageSpec.name
# Max unavailable pods for the fe component when doing rolling update.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s / fe component/cn component

@@ -946,6 +959,12 @@ starrocksBeSpec:
# volumeMounts:
# - mountPath: /opt/starrocks/be/storage
# name: be-data # append -data to the end of the name of the starrocksBeSpec.storageSpec.name
# Max unavailable pods for the fe component when doing rolling update.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s / fe component/be component

@@ -791,6 +798,12 @@ starrocks:
# volumeMounts:
# - mountPath: /opt/starrocks/cn/storage
# name: cn-data # append -data to the end of the name of the starrocksCnSpec.storageSpec.name
# Max unavailable pods for the fe component when doing rolling update.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s / fe component/cn component

@@ -1054,6 +1067,12 @@ starrocks:
# volumeMounts:
# - mountPath: /opt/starrocks/be/storage
# name: be-data # append -data to the end of the name of the starrocksBeSpec.storageSpec.name
# Max unavailable pods for the fe component when doing rolling update.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s / fe component/be component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.9.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants